RFR: 8351368: RichTextArea: exception pasting from Word

Kevin Rushforth kcr at openjdk.org
Thu Mar 6 23:54:00 UTC 2025


On Thu, 6 Mar 2025 23:16:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> The original code used String attribute keys.
> 
> I'd like to backport this fix to jfx24u.

This is a simple enough fix that a single reviewer should be sufficient.

modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/rtf/RTFReader.java line 787:

> 785:                 Object stype = defined.getAttribute(STYLE_TYPE);
> 786:                 Map<Integer, Style> toMap;
> 787:                 if (STYLE_SECTION.equals(stype)) {

Since this is a marker object, should it be `==` rather than `.equals`? They are equivalent, so it's up to you.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1731#pullrequestreview-2665858008
PR Review Comment: https://git.openjdk.org/jfx/pull/1731#discussion_r1984190205


More information about the openjfx-dev mailing list