RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

John Hendrikx jhendrikx at openjdk.org
Mon Mar 10 08:39:06 UTC 2025


On Sun, 9 Mar 2025 22:36:42 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerManager.java line 64:
> 
>> 62:      * @param instance the instance to which the listeners belong, cannot be {@code null}
>> 63:      * @param listener a listener to add, cannot be {@code null}
>> 64:      * @throws NullPointerException when listener is {@code null}
> 
> And when `instance` is too, no? One will throw implicitly and the other explicitly. Does it matter for the docs?

I've updated all of these to `throws NullPointerException when any argument is {@code null}`

How it is done exactly is irrelevant for the docs :)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1986823574


More information about the openjfx-dev mailing list