RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]
Nir Lisker
nlisker at openjdk.org
Tue Mar 11 02:37:04 UTC 2025
On Mon, 10 Mar 2025 08:42:07 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerManager.java line 53:
>>
>>> 51: * within listener list. If possible use {@link ListenerManager}, as it has less
>>> 52: * storage requirements and is faster.
>>> 53: *
>>
>> I suggest adding a line that says that this class is used by properties.
>
> That doesn't seem like something you should be adding to the docs I think?
Up to you. I thought it would make it easier on anyone learning the implementations if they understood why 2 are needed (one that stores the value and one that relies on the value being stored elsewhere).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1988273974
More information about the openjfx-dev
mailing list