RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

[Nir Lisker]

On Mon, 10 Mar 2025 07:37:27 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> > First part of the review.
> > There are several class (and their methods) that are `public`, but are only used in their package and can just have package-access: `OldValueCachingListenerList` `ListenerManagerBase` `ListenerListBase` `ListenerList` `ArrayManager`
> > If they are `public` because of tests, please add a comment like "public for testing purpose"
> 
> I understand that making a **method** public that shouldn't be should be documented as such, but what's against having public classes in non-exported packages even if just for testing purposes? This is done widely through out FX already.
> 
> Also these classes are well documented, and there's no reason they could not be used outside their package, even if they currently are not.

I tend to restrict visibility unless necessary, especially when some classes function as helper classes, but it's fine to leave as is.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1081#issuecomment-2712389612