RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

[Michael Strauß]

On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Allows MenuBar to be created in a background thread by delaying MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8350976.menubarskin.thread.safety
>  - spelling
>  - use system menu
>  - cleanup
>  - possible fix
>  - test

modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java line 233:

> 231: 
> 232:         if (Platform.isFxApplicationThread()) {
> 233:             if (Toolkit.getToolkit().getSystemMenu().isSupported()) {

You could move this check to the outer scope, because if it evalutes to false, we can skip both branches of `if (Platform.isFxApplicationThread()) {` completely.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1727#discussion_r1992698653