RFR: 8351878: RichTextArea: Pasting from RTF doesn't apply formatting [v3]
Andy Goryachev
angorya at openjdk.org
Mon Mar 17 16:29:59 UTC 2025
On Mon, 17 Mar 2025 15:21:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixed two issues found in importing RTF text:
>>
>> - charset translation (brought back removed code)
>> - missing font size attribute
>> - missing strike-through attribute
>>
>> The charset issue was caused by my removal of the character decoder code present in the original JDK RTF parser/reader. Why did I do that?
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>
> arabic
@Ziad-Mid : please take a look at this PR.
Please refer to https://github.com/openjdk/jfx/blob/master/README-code-reviews.md for general guidance.
The areas I would like you to focus on specifically are:
- pasting Arabic from other RTF sources (outlook, other applications?)
- think of any other possible problems or side effects of the proposed change
- verifying the tests fail in the `master` branch and passing with the fix
- anything else you might find suboptimal or unclear
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1735#issuecomment-2730137021
More information about the openjfx-dev
mailing list