RFR: 8313424: JavaFX controls in the title bar [v56]

[Michael Strauß]

On Mon, 17 Mar 2025 21:00:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   enable preview features in tests
>
> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 79:
> 
>> 77:         if (enabledForTesting) {
>> 78:             // do nothing
>> 79:         } else if (!enabled) {
> 
> `if (!enabledForTesting && !enabled) {` ?

I would have to surround both branches (if and else), as otherwise the warning will be emitted during tests. That would, however, increase nesting…

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2000212445