RFR: 8335547: Support multi-line prompt text for TextArea
Andy Goryachev
angorya at openjdk.org
Thu Mar 20 14:46:26 UTC 2025
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:
> Added multi line prompt support for TextArea this will provide the ability to have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
I think it currently looks good, even though `PasswordField` lost its portion of tests. Since we know the `PasswordField` implementation does not add any functionality in the area being tested, the TextFieldTest should be sufficient.
Left some minor comments.
I would like to have another pair of eyes though.
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java line 29:
> 27:
> 28: import java.util.List;
> 29: import javafx.beans.binding.*;
please do not use wildcard imports
modules/javafx.controls/src/test/java/test/javafx/scene/control/TextAreaTest.java line 28:
> 26: package test.javafx.scene.control;
> 27:
> 28: import static org.junit.jupiter.api.Assertions.*;
please do not use wildcard imports
-------------
PR Review: https://git.openjdk.org/jfx/pull/1716#pullrequestreview-2703011020
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2005798638
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2005800412
More information about the openjfx-dev
mailing list