RFR: 8313424: JavaFX controls in the title bar [v22]

[Michael Strauß]

On Tue, 5 Nov 2024 23:00:36 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - HeaderBar changes
>>  - EMPTY Dimension2D constant
>>  - use CsvSource in HeaderBarTest
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/HeaderBarTest.java line 237:
> 
>> 235:         "BOTTOM_RIGHT, 740, 40, 100, 50"
>> 236:     })
>> 237:     void alignmentOfCenterChild_notResizable_withNonEmptyLeadingAndTrailingChild(
> 
> minor suggestion:
> 
> long test names do not help much (and actually may cause problems, see https://bugs.openjdk.org/browse/JDK-8334497)
> 
> also rather inconvenient to see in the logs, or IDEs.  You can use comments for human-readability and short(er) method names.

I've thought about it for a bit, and decided to leave it as-is for this class.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2009051894