RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Mon Mar 24 10:18:13 UTC 2025
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Allows MenuBar to be created in a background thread by delaying MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into 8350976.menubarskin.thread.safety
> - spelling
> - use system menu
> - cleanup
> - possible fix
> - test
Looks good, verified on Windows 11 - test fails without fix and works with it.
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1727#pullrequestreview-2709843635
More information about the openjfx-dev
mailing list