RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v4]
John Hendrikx
jhendrikx at openjdk.org
Mon Mar 24 21:24:15 UTC 2025
On Mon, 24 Mar 2025 17:55:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> I think you are onto something here. It almost feels like we shouldn't be doing ceil/floor at all, rounding to the closest pixel instead.
>
> This would be a much larger change, though. Perhaps something to consider for a future discussion.
@kevinrushforth Yes, I wasn't intending to do anything about this in this change as it is unrelated. I understand why `ceil` is used; FX distinguishes between sizes and spaces, where sizes are part of some visual part of a control, and spaces are non-control areas. Spaces are generally ceil'd, so that even the thinnest control or border would show up as 1 pixel, while positions and spaces are just rounded. Still, a border that would end up being 0.0001 pixels wide probably is still best hidden completely.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1723#discussion_r2010943657
More information about the openjfx-dev
mailing list