RFR: 8342565: [TestBug] StubTextLayout [v9]

[Andy Goryachev]

On Tue, 25 Mar 2025 17:43:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "fixed bad merge"
>>   
>>   This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/chart/StackedBarChartTest.java line 116:
> 
>> 114:         String bounds = computeBoundsString((Region)childrenList.get(0), (Region)childrenList.get(1),
>> 115:                 (Region)childrenList.get(2));
>> 116:         assertEquals("10 440 216 34 236 397 216 77 461 345 216 129 ", bounds);
> 
> I presume these changes are needed because they are also hard-coded values that are changing with the StubToolkit changes?

correct

> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java line 100:
> 
>> 98: import test.com.sun.javafx.scene.control.test.RT_22463_Person;
>> 99: 
>> 100: /**
> 
> Minor: We don't typically use javadoc-style comments in the class docs of test classes, but since we have a global RFE to address this, I don't think it matters all that much.

I usually do javadoc comments, because they show up in Eclipse when I click on the class name.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1667#discussion_r2012978540
PR Review Comment: https://git.openjdk.org/jfx/pull/1667#discussion_r2012980256