RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v2]

[Andy Goryachev]

On Fri, 28 Mar 2025 21:10:46 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - testing: inject a failure
>>  - review comments
>
> tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 71:
> 
>> 69:     @Override
>> 70:     public void testAborted(ExtensionContext extensionContext, Throwable err) {
>> 71:         err.printStackTrace();
> 
> Is this needed or is it just for debugging? We already get a stack trace when a test fails, so it might be redundant.

Good point - it's not needed.  The junit framework outputs a truncated stack trace which should be sufficient:


TextAreaBehaviorRobotTest > fail() FAILED
    java.lang.Error
        at test.robot.javafx.scene.control.behavior.TextAreaBehaviorRobotTest.fail(TextAreaBehaviorRobotTest.java:49)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1746#discussion_r2021561824