RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug

Andy Goryachev angorya at openjdk.org
Fri May 2 19:16:49 UTC 2025


On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .

Looks good.  Thanks for the test, nice idea with the "double-parameterized" case.

1 reviewer should be sufficient.  Please wait 24 hrs before integrating.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1801#pullrequestreview-2812733235


More information about the openjfx-dev mailing list