RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug

[Michael Strauß]

On Fri, 2 May 2025 20:38:39 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> We already have `fontSetFromCSS()` test there, so I am not against adding a test in this file.

That's not my point. `fontSetFromCSS` tests whether a font can be set via CSS, which concerns the implementation of `TextInputControl`. In contrast to that, the test in this PR doesn't test any aspect of `TextInputControl` at all. It tests the Modena theme, which doesn't belong here.
 
> You do bring a good point though, which is whether we should do in respect to CSS. Perhaps we should add a set of tests that verify that CSS properties are loaded from
> 
> * inline style
> * scene stylesheet
> * user agent stylesheet
> 
> (unless we have these tests already)

This seems a bit too much, since we already have tests for the CSS infrastructure that applies values to styleable properties. I don't think we need to repeat that for each individual property, at least not manually.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2848124960