RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug

[Michael Strauß]

On Fri, 2 May 2025 23:27:38 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

> I can put the test in the `StylesheetTest` class, which might be more appropriate for this case. what do you think ?

No, because you're not testing the `Stylesheet` class either. What you are doing is testing the Modena theme, for which we have no appropriate testing methodology in JavaFX. I would rather just remove the test entirely, because this new test is going to be another person's future work. It's also more of a change tracker than a unit test, as a style is not a meaningful unit of code. If we want to start testing stylesheets, we should first have a discussion on goals and methodology.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2848482322