RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug
Marius Hanl
mhanl at openjdk.org
Sat May 3 15:05:49 UTC 2025
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .
I think the tests are still nice, but we might want to have a separate test class, something like `ModenaStylesheetTest`?
I see your point that we are testing the modena stylesheet only here, but that itself is fine in my opinion.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1801#issuecomment-2848663962
More information about the openjfx-dev
mailing list