RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v2]

Ziad El Midaoui zelmidaoui at openjdk.org
Mon May 5 14:27:17 UTC 2025


> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .

Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:

  Created ModenaTest

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1801/files
  - new: https://git.openjdk.org/jfx/pull/1801/files/9ef0c212..50627c42

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1801&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1801&range=00-01

  Stats: 131 lines in 2 files changed: 98 ins; 33 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1801.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1801/head:pull/1801

PR: https://git.openjdk.org/jfx/pull/1801


More information about the openjfx-dev mailing list