RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v2]
Kevin Rushforth
kcr at openjdk.org
Mon May 5 14:34:52 UTC 2025
On Mon, 5 May 2025 14:27:17 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .
>
> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>
> Created ModenaTest
modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTest.java line 1:
> 1: package test.com.sun.javafx.scene.control.skin.modena;
You need a standard copyright header.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1801#discussion_r2073571915
More information about the openjfx-dev
mailing list