RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v2]

[Andy Goryachev]

On Mon, 5 May 2025 14:27:17 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

>> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .
>
> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Created ModenaTest

modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTest.java line 23:

> 21: import static org.junit.jupiter.api.Assertions.fail;
> 22: 
> 23: public class ModenaTest {

perhaps add a javadoc describing what this file is supposed to test?

modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/ModenaTest.java line 33:

> 31:     }
> 32: 
> 33:     private TextInputControl textInput;

Since this test tests `modena.css` aspects of the `TextInputControl` class hierarchy, should this test be renamed then (`TextInputControlModena` or something like that)?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1801#discussion_r2073598355
PR Review Comment: https://git.openjdk.org/jfx/pull/1801#discussion_r2073597590