RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v3]

Andy Goryachev angorya at openjdk.org
Mon May 5 17:59:57 UTC 2025


On Mon, 5 May 2025 17:37:31 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

>> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .
>
> Ziad El Midaoui has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Added standard copyright, javadoc and changed file name to TextInputControlModenaTest
>  - Added standard copyright, javadoc and changed file name to TextInputControlModenaTest

Marked as reviewed by angorya (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1801#pullrequestreview-2815626315


More information about the openjfx-dev mailing list