RFR: 8345348: CSS media feature queries [v20]

Andy Goryachev angorya at openjdk.org
Mon May 5 18:56:04 UTC 2025


On Mon, 28 Apr 2025 07:38:37 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Implementation of [CSS media queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
> 
>  - Merge branch 'master' into feature/media-queries
>  - reorder fields
>  - remove ReadOnlyBooleanWrapper
>  - Scene preferences only actively observe platform preferences when the scene is showing
>  - formatting
>  - typo
>  - use equality instead of identity
>  - rename TokenStream methods
>  - improved implementation of NullCoalescingPropertyBase
>  - small refactor
>  - ... and 18 more: https://git.openjdk.org/jfx/compare/3fdd2138...32abb8a3

modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 838:

> 836:         An empty media query list evaluates to <code>true</code>.
> 837:         <figure style="margin: 0">
> 838:             <img src="media-query.svg" width="210" alt="Media Query List">

did you create these images yourself?

modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 871:

> 869:             <code>(prefers-color-scheme: dark) and (prefers-reduced-motion) or (prefers-reduced-transparency)</code>
> 870:             is illegal, as it is unclear what was meant. In this case, parentheses must be used to group expressions.
> 871:     </ul>

maybe one or two examples would be helpful here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2072225901
PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2072227142


More information about the openjfx-dev mailing list