RFR: 8355012: JavaFX modena.css -fx-highlight-text-fill bug [v4]

Ziad El Midaoui zelmidaoui at openjdk.org
Mon May 5 21:28:08 UTC 2025


> The issue was happening because `-fx-highlight-text-fill` was set to white , so when the background color is bright (>60% brightness ) the text is not visible , the solution is to change the value to be dynamically set depending on the level of brightness of the background this is done by `-fx-focused-text-base-color` .

Ziad El Midaoui has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'openjdk:master' into 8355012.modenaCss
 - Added standard copyright, javadoc and changed file name to TextInputControlModenaTest
 - Added standard copyright, javadoc and changed file name to TextInputControlModenaTest
 - Created ModenaTest
 - Changed value of -fx-highlight-text-fill to be dynamically set and added tests

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1801/files
  - new: https://git.openjdk.org/jfx/pull/1801/files/7320ee66..e3ad18c0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1801&range=03
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1801&range=02-03

  Stats: 123781 lines in 294 files changed: 29355 ins; 52007 del; 42419 mod
  Patch: https://git.openjdk.org/jfx/pull/1801.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1801/head:pull/1801

PR: https://git.openjdk.org/jfx/pull/1801


More information about the openjfx-dev mailing list