RFR: 8345348: CSS media feature queries [v23]

[Michael Strauß]

On Tue, 6 May 2025 15:08:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve synchronization in PreferenceProperties
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PreferenceProperties.java line 312:
> 
>> 310: 
>> 311:         // This method must only be called when synchronized on 'mutex'.
>> 312:         public void updateEffectiveValue() {
> 
> maybe make this method private then: the instance of this class is available via `Platform.getPreferences()` if I read this correctly

No, the instance of `PreferenceProperties` only stored as a private field in `PlatformPreferences`. I'm usually using public methods in nested classes to indicate that the method is supposed to be called from outside of the nested class. That's not strictly necessary, but I think it serves to differentiate them from "purely" private methods.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2077215278