RFR: 8345348: CSS media feature queries [v23]

[Andy Goryachev]

On Wed, 7 May 2025 15:16:15 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> okay
>
> Further, if you call `setAccessibile` in connection with `--add-opens`, which your above code snippet does, you can even call _private_ methods.
> 
> So at the risk of repeating myself, there is no concern that making this method public exposes it to applications. However, making it package-scope if it doesn't need to be public, is a best practice if it doesn't need to be accessed outside the package.

yes, I agree - thanks for the discussion!

(and `setAccessible()` is not needed with `--add-opens`)

I withdraw my comments - making these methods `private` is not needed, `public` or package-scope is fine.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1655#discussion_r2077914653