RFR: 8340344: The first item in TreeView is not aligned in the beginning [v2]

[Ziad El Midaoui]

On Wed, 7 May 2025 23:09:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update TreeCellSkin.java
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 226:
> 
>> 224: 
>> 225:                     final VirtualFlow<?> flow = getVirtualFlow();
>> 226:                     for (IndexedCell cell : flow.cells) {
> 
> `getVirtualFlow()` might return null, right?

Yes,
I added a check for null value

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 261:
> 
>> 259:         Parent p = getSkinnable();
>> 260:         while (p != null) {
>> 261:             if (p instanceof VirtualFlow) {
> 
> can be simplified:
> 
> 
> if (p instanceof VirtualFlow vf) {
>   return vf;

I made the change , thanks

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2079888335
PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2079888974