RFR: 8340344: The first item in TreeView is not aligned in the beginning [v4]

Andy Goryachev angorya at openjdk.org
Thu May 8 20:43:57 UTC 2025


On Thu, 8 May 2025 20:16:12 GMT, Ziad El Midaoui <zelmidaoui at openjdk.org> wrote:

>> The issue occurred because items preceding an item with children (items with a disclosure node) had different widths, which led to misalignment. This can be fixed by requesting a cell relayout whenever the disclosure node's width changes.
>
> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed minor issue with test

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 228:

> 226:                     if (flow != null) {
> 227:                         for (IndexedCell cell : flow.cells) {
> 228:                             if (cell != null || !cell.isEmpty()) {

it has to be `&&`

`if (cell != null && !cell.isEmpty()) {`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2080435561


More information about the openjfx-dev mailing list