RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v18]
Thiago Milczarek Sayao
tsayao at openjdk.org
Sun May 11 12:26:01 UTC 2025
On Wed, 7 May 2025 13:40:13 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix non-debug build
>
> tests/system/src/test/java/test/robot/javafx/stage/StageLocationTest.java line 91:
>
>> 89: stage.setY(Y);
>> 90: },
>> 91: stage::show,
>
> On my Windows 11 machine this consistently fails for DECORATED stage, which is the very first test to be done from the collection. My guess is that this misses a `CountDownLatch` or some other way to ensure the Stage is fully shown.
>
> I would also add a similar latch wait to other tests in this file. A common `showStage` method of sorts that calls `stage::show` and then waits for the latch seems to me like the best route. Plenty of other system tests use this pattern if you need to source the solution from somewhere.
Shown latches added.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2083510016
More information about the openjfx-dev
mailing list