RFR: 8355615: ConcurrentModificationException creating MenuBar on background thread [v2]
Ziad El Midaoui
zelmidaoui at openjdk.org
Wed May 14 14:29:58 UTC 2025
On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Moving MenuBarSkin initialization code to install() which always happens in the FX Application Thread.
>>
>> Also, ensure that the reverse process also happens in the FX application thread.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into 8355615.menubar
> - in fx thread
> - install
LGTM.
I also confirmed that the test doesn't fail on my system without the fix. That said, the fix looks good and addresses the issue.
-------------
Marked as reviewed by zelmidaoui (Author).
PR Review: https://git.openjdk.org/jfx/pull/1795#pullrequestreview-2840438233
More information about the openjfx-dev
mailing list