RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level
Michael Strauß
mstrauss at openjdk.org
Thu May 15 17:56:59 UTC 2025
On Thu, 15 May 2025 11:27:21 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
> This follow-up change finishes the earlier changes to `ImageStorage.loadAll()` and adds support for loading specific scale requested in the input.
>
> `loadAll()` will now first check if the input path ends with a scaling level specified, and if that is the case it will attempt creating a Stream. If requested resource does not exist it will throw an Exception, skipping the rest of the load process. If the resource does _not_ have a scaled name in its path, it will continue loading as normal - looking for all scale levels, trying to load the main resource and falling back to trying to load "@1x" variant.
>
> Added tests to check the new `ImageTools.hasScaledName()` method + new behavior.
Looks good.
-------------
Marked as reviewed by mstrauss (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1809#pullrequestreview-2844567664
More information about the openjfx-dev
mailing list