RFR: 8357067: Platform preference change can emit multiple notifications
Andy Goryachev
angorya at openjdk.org
Thu May 15 18:37:58 UTC 2025
On Thu, 15 May 2025 18:28:59 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/win/PlatformSupport.h line 75:
>>
>>> 73: * Suggested aggregation delay for changes that come in over a period of time.
>>> 74: */
>>> 75: static constexpr int SUGGESTED_DELAY_MILLIS = 1000;
>>
>> 1 second seems too long.
>> What is the typical range for the high contrast train of changes?
>
> Quite a lot, Windows takes around 1-2 seconds to change to and from a high-contrast theme (there's even a full-frame wait screen that pops up). The suggested delay of 1 second works reliably on my machine.
If it takes that long to update all the colors, maybe we should not add complexity to this subsystem and just send the events as they come?
What exactly is the problem the user experiences right now?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1810#discussion_r2091764273
More information about the openjfx-dev
mailing list