RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

[Michael Strauß]

On Fri, 16 May 2025 18:27:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/AbstractPrimaryTimer.java line 380:
> 
>> 378:                     Thread thread = Thread.currentThread();
>> 379:                     thread.getUncaughtExceptionHandler().uncaughtException(thread, e);
>> 380:                 } catch (Throwable ignored) {
> 
> any reason not to wrap the whole method in `try`/`catch`?

There isn't anything else in there that could throw, except for the logger itself. I don't think it makes sense to try to account for failing loggers, as basically everything will break if that's the case.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1811#discussion_r2093520616