RFR: 8356652: Input field ignores custom input source characters [v2]

Andy Goryachev angorya at openjdk.org
Mon May 19 14:22:58 UTC 2025


On Fri, 16 May 2025 22:25:20 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Under the hood the Keyman input method appears as a US English keyboard layout. The characters attached to an NSEvent are always US English Roman even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends the correct Hebrew or Dvorak character to insertText:replacementRange: instead.
>> 
>> This PR special-cases the Keyman layout, detecting it using the same method that AWT does. When Keyman is active Glass records the insertText: character and uses that when sending out KeyEvents.
>
> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Second try at making Keyman work to some extent

Thank you for clarification!

This PR fixes the issues with multiple keyman keyboards without introducing regressions with the normal keyboard or the IME.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1805#pullrequestreview-2850953021


More information about the openjfx-dev mailing list