RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]
Lukasz Kostyra
lkostyra at openjdk.org
Mon May 19 14:27:56 UTC 2025
On Mon, 19 May 2025 07:06:38 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> This follow-up change finishes the earlier changes to `ImageStorage.loadAll()` and adds support for loading specific scale requested in the input.
>>
>> `loadAll()` will now first check if the input path ends with a scaling level specified, and if that is the case it will attempt creating a Stream. If requested resource does not exist it will throw an Exception, skipping the rest of the load process. If the resource does _not_ have a scaled name in its path, it will continue loading as normal - looking for all scale levels, trying to load the main resource and falling back to trying to load "@1x" variant.
>>
>> Added tests to check the new `ImageTools.hasScaledName()` method + new behavior.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>
> Update regex, add tests for @0x and @-1x
>
> Capture group for the extension after scale was changed to non-capturing
> group
All checks passed so I'll merge this one. Thanks for review everyone!
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1809#issuecomment-2891234299
More information about the openjfx-dev
mailing list