RFR: 8340344: The first item in TreeView is not aligned in the beginning [v6]

[Ziad El Midaoui]

On Wed, 21 May 2025 05:09:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid re-layout items twice after disclosure node width value updated
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 232:
> 
>> 230:                                 cell.requestLayout();
>> 231:                                 cell.layout();
>> 232:                             }
> 
> Just a minor change please.
> The for loop could break when `cell.getIndex() >= indexWithDisclosureNode`, so that we avoid looping through the cells that are after disclosureNode.
> 
> 
> for (IndexedCell cell : flow.cells) {
>     if (cell != null) {
>         if (cell.getIndex() >= indexWithDisclosureNode) {
>             break;
>         } else if (!cell.isEmpty()) {
>             cell.requestLayout();
>             cell.layout();
>         }
>     }
> }

Thanks for the suggestion,
I have pushed new changes.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1715#discussion_r2099917922