RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v30]
Andy Goryachev
angorya at openjdk.org
Tue May 27 15:06:44 UTC 2025
On Thu, 22 May 2025 21:47:22 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 59 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - cleanup
>> - removed getStrikeThroughShape
>> - caret geometry
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - sealed
>> - indent
>> - ... and 49 more: https://git.openjdk.org/jfx/compare/59c2b759...ab8bd9cb
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismLayoutInfo.java line 74:
>
>> 72: TextLine[] lines = layout.getLines();
>> 73: Insets m = insets();
>> 74: double dx = m.getLeft(); // TODO rtl?
>
> This comment looks like it's a question to the reader. Does the code not work for RTL layouts?
JavaFX does not support RTL fully - there is a whole series of issues waiting to be fixed.
See https://bugs.openjdk.org/browse/JDK-8343557
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2103461360
More information about the openjfx-dev
mailing list