RFR: 8091429: ObservableList<E>#replaceRange(int from, int to, Collection<? extends E> col) [v2]
John Hendrikx
jhendrikx at openjdk.org
Sun Nov 2 00:52:19 UTC 2025
On Mon, 20 Oct 2025 05:06:20 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> This PR implements two new default methods on `ObservableList` to be able to replace elements at a given position or within a specified range.
>>
>> Justification for this change is to allow an `ObservableList` to be bulk modified resulting in a single `ListChangeListener` call back. In this way the callbacks don't observe the list changing its size from S to S-X back to S again(*). Currently the only way to bulk replace a range of items is to remove X items then add X items, resulting in two listener callbacks in between which the size of the list can be observed to change.
>>
>> The other alternative is to call `set` individually for each item, which results in many change notifications.
>>
>> With the addition of this PR, and the changes in `ModifiableObservableListBase`, replacing a range of items becomes a single change callback.
>>
>> (*) The list may indeed change size still as plain `List` does not have `setAll` operations; size listeners may observe this, but it will no longer be observable from a `ListChangeListener` due to multiple separate callbacks.
>
> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix test
> - Rename setAll to replaceRange and removed superfluous method
Looks like I'll need this change to write a test for replacing a range of elements in ListView. It seems that currently replacing a range of items will always clear the whole selection. Filed https://bugs.openjdk.org/browse/JDK-8371090 to track those problems.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1937#issuecomment-3477012798
More information about the openjfx-dev
mailing list