RFR: 8091429: ObservableList<E>#replaceRange(int from, int to, Collection<? extends E> col) [v3]
Kevin Rushforth
kcr at openjdk.org
Thu Nov 6 00:08:18 UTC 2025
On Wed, 5 Nov 2025 16:19:36 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> This PR implements a new default method on `ObservableList` to be able to replace elements within a specified range.
>>
>> Justification for this change is to allow an `ObservableList` to be bulk modified resulting in a single `ListChangeListener` call back. In this way the callbacks don't observe the list changing its size from S to S-X back to S again(*). Currently the only way to bulk replace a range of items is to remove X items then add X items, resulting in two listener callbacks in between which the size of the list can be observed to change.
>>
>> The other alternative is to call `set` individually for each item, which results in many change notifications.
>>
>> With the addition of this PR, and the changes in `ModifiableObservableListBase`, replacing a range of items becomes a single change callback.
>>
>> (*) The list may indeed change size still as plain `List` does not have `setAll` operations; size listeners may observe this, but it will no longer be observable from a `ListChangeListener` due to multiple separate callbacks.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>
> Add additional tests
-------------
Changes requested by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1937#pullrequestreview-3425035523
More information about the openjfx-dev
mailing list