RFR: 8370446: Support dialogs with StageStyle.EXTENDED [v2]

[Michael Strauß]

On Thu, 6 Nov 2025 20:54:00 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move HeaderBar to DialogPane
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Dialog.java line 467:
> 
>> 465:      * Specifies the style for this dialog. This must be done prior to making the dialog visible.
>> 466:      * <p>
>> 467:      * Note that a dialog with the {@link StageStyle#EXTENDED} style must also specify a {@link HeaderBar} with
> 
> must or should?  meaning, is it a requirement, or just a warning?
> if the latter, it might be better to say something like "the dialog will not be draggable if the header bar is not set"

You're right, it's more like a warning. I've changed it to "should".

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1943#discussion_r2501422702