RFR: 8371183: RichTextModel: ContentChange.isEdit incorrect undoing style modification
Kevin Rushforth
kcr at openjdk.org
Mon Nov 10 19:22:10 UTC 2025
On Tue, 4 Nov 2025 20:32:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> Fixes an issue found by an external user:
>
> Undoing a style only change fires a change event where `ContentChange.isEdit` is true when it should be false.
>
> NOTE
>
> - this PR depends on #1941 (resolved)
I left a comment on the docs of a public API method that I think should be reverted.
I'll let someone else review and test the fix itself.
modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java line 1105:
> 1103: * <p>
> 1104: * This convenience method is equivalent to calling
> 1105: * {@code appendText(text, StyleAttributeMap.EMPTY, true);}
There is no such method, so this should be reverted. I don't see why this bug fix would even need a change to the public API docs.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1961#pullrequestreview-3444741662
PR Review Comment: https://git.openjdk.org/jfx/pull/1961#discussion_r2511663845
More information about the openjfx-dev
mailing list