RFR: 8371183: RichTextModel: ContentChange.isEdit incorrect undoing style modification [v2]
Lukasz Kostyra
lkostyra at openjdk.org
Tue Nov 11 13:18:22 UTC 2025
On Mon, 10 Nov 2025 19:49:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Fixes an issue found by an external user:
>>
>> Undoing a style only change fires a change event where `ContentChange.isEdit` is true when it should be false.
>>
>> NOTE
>>
>> - this PR depends on #1941 (resolved)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>
> bad merge
LGTM. I verified the test on Windows and playing around a short bit with Rich Editor, everything works fine.
Despite ~60 lines changed, this change is trivial (adding an extra flag and acting upon it in one place) and IMHO does not need a second reveiwer.
-------------
Marked as reviewed by lkostyra (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1961#pullrequestreview-3448023601
More information about the openjfx-dev
mailing list