RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v2]

[Prasanta Sadhukhan]

On Wed, 12 Nov 2025 17:00:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   debug fix
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 286:
> 
>> 284:         super();
>> 285: 
>> 286:         debug_println("JFXPanel Thread " + Thread.currentThread().getName() + " isFXUserThread " + Toolkit.getToolkit().isFxUserThread());
> 
> Basically, here (and elsewhere debug_println() is called) we should have
> 
> if(DEBUG) {
>           debug_println("JFXPanel Thread " + Thread.currentThread().getName() + " isFXUserThread " + Toolkit.getToolkit().isFxUserThread());
> }
> 
> 
> As a separate note, you may want to consider removing some noise from debugging output and only print when "unexpected" condition occurs, such as (thread != fx), right?

I guess different method will have different unexpected condition so I kept it generic to crosscheck if calling thread are indeed what it should be..

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1968#discussion_r2521176030