RFR: 8371859: Dialog unnecessarily invokes DialogPane.requestLayout()

John Hendrikx jhendrikx at openjdk.org
Fri Nov 14 08:40:41 UTC 2025


On Thu, 13 Nov 2025 23:20:48 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> > ... because it's the case when layout needs multiple pulses to get settled?
> 
> Yes, it seems that that's the case. One more reason to switch to an iterative layout algorithm.

I don't think it needs settling in this case, it is just an ancient bug with the layout X/Y properties in Node that have a guard that doesn't work (the `isCurrentLayoutChild` effectively does nothing).  Therefore a 2nd layout is always triggered that just "confirms" all values again -- the confirmation doesn't lead to another layout as the layout X/Y properties are smart enough to not care when their values are set to the exact same value.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1973#issuecomment-3531598941


More information about the openjfx-dev mailing list