RFR: 8356770: TreeTableView not updated after removing a TreeItem with children and adding it to another parent [v2]
Ziad El Midaoui
zelmidaoui at openjdk.org
Fri Nov 14 15:27:30 UTC 2025
On Fri, 14 Nov 2025 09:27:39 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 6471:
>
>> 6469:
>> 6470: // Find "item B" row and record its disclosure node indent
>> 6471: TreeTableRow<String> rowBefore = findRow(table, "item B");
>
> I would recommend using `VirtualFlowTestUtils.getVirtualFlow(table).getVisibleCell(index);`
> The index should be easy to find out, since we always know where the `TreeItem` should be.
Yes exact, I usually prefer not to hardcode things, but sure in this case I will modify it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1971#discussion_r2527894949
More information about the openjfx-dev
mailing list