RFR: 8250802: Refactor StringConverter and its subclasses [v2]

Nir Lisker nlisker at openjdk.org
Wed Nov 19 00:36:02 UTC 2025


On Mon, 17 Nov 2025 22:34:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> I second John's suggestion with `this.`. It matters when refactoring, even with an IDE.

I'm not sure what you want me to change here exactly. Is it about renaming parameters (see [this discussion](https://github.com/openjdk/jfx/pull/1880#discussion_r2297668458)), or not using `this`, which you didn't seem to mind [here](https://github.com/openjdk/jfx/pull/1880#discussion_r2297721228)?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2540042087


More information about the openjfx-dev mailing list