RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Nir Lisker
nlisker at openjdk.org
Wed Nov 19 00:49:45 UTC 2025
On Mon, 17 Nov 2025 23:09:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - review comments 2
>> - review comments 1
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/CurrencyStringConverterTest.java line 58:
>
>> 56: void testConstructor_locale() {
>> 57: NumberFormat numberFormat = NumberFormat.getCurrencyInstance(Locale.CANADA);
>> 58:
>
> very minor: extra newlines?
To separated the part that created the expected result and the actual result.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2540071517
More information about the openjfx-dev
mailing list