RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v8]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Nov 19 17:14:55 UTC 2025
On Wed, 19 Nov 2025 16:52:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassScene.java line 254:
>
>> 252: // should only be called on the event thread
>> 253: if (getSceneState() != null) {
>> 254: sceneState.update();
>
> Suggestion:
>
> if (sceneState != null) {
> sceneState.update();
>
>
> Minor: it seems cleaner to access `sceneState` directly in both the test and usage rather than mixing them.
ok
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1968#discussion_r2542898330
More information about the openjfx-dev
mailing list