RFR: 8250802: Refactor StringConverter and its subclasses [v2]

Andy Goryachev angorya at openjdk.org
Wed Nov 19 20:46:17 UTC 2025


On Wed, 19 Nov 2025 20:15:46 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Not exactly, if I read it right.
>> The lenient flag is not set if the format is specified in the constructor - see L204 in the original class.  The new code clears this flag regardless.
>
> Maybe I'm missing something. The constructor that takes a `DateFormat` directly in the new code is
> 
>     public DateTimeStringConverter(DateFormat dateFormat) {
>         this.dateFormat = dateFormat != null ? dateFormat :
>                 create(DEFAULT_LOCALE, DateFormat.DEFAULT, DateFormat.DEFAULT, null);
>     }
> 
> So `DateFormat#create` isn't called and `setLenient` isn't called.

you are right!  I did not see it's not a constructor (must be turning blind).  please disregard.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2543509924


More information about the openjfx-dev mailing list