RFR: 8372275: NPE in D3DResourceFactory.createPresentable

Kevin Rushforth kcr at openjdk.org
Thu Nov 27 00:04:59 UTC 2025


On Wed, 26 Nov 2025 11:39:28 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> This PR solves potential NPE in `D3DResourceFactory.createPresentable`.
> 
> The mistake was quite obvious, creating an RTT can potentially return `null` due to lack of resources available in the system. If that happens while dirty opts are enabled, `rtt` would be dereferenced by calling `rtt.contentsUseful()`.
> 
> The fix is to move the check to after we check if `rtt` is null.

LGTM

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1987#pullrequestreview-3513065683


More information about the openjfx-dev mailing list