RFR: JDK-8210547 synchronise with OpenGL after the last window is presented [v2]

Lukasz Kostyra lkostyra at openjdk.org
Thu Nov 27 13:23:12 UTC 2025


On Tue, 25 Nov 2025 00:33:41 GMT, notzed <duke at openjdk.org> wrote:

>> As discussed on the mailing list.
>> 
>> OpenGL requires an explicit glFinish() to synchronise with the video refresh.  The current usage is incorrect and against the specification.  This patch calls glFinish() after all windows have been drawn following a pulse.
>
> notzed has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   JDK-8210547 synchronise with OpenGL after the last window is presented

I tested your changes but they do not fix the original problem which #1929 addresses. I just tested this on my Intel UHD machine and the framerate is not tied to VSync (FPS meter from the original issue is around 1000fps instead of 60fps).

I think it's getting pretty confusing regarding both this change and Thiago's PR, so I would like to figure some things out before we progress. I looked back into the mailing list discussion but I'm still not fully clear on everything.

Is this change actually supposed to address the problem from [JDK-8210547](https://bugs.openjdk.org/browse/JDK-8210547)? If so, is this change in place of #1929 or does it depend on it?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1981#issuecomment-3585831140


More information about the openjfx-dev mailing list